Remove panic from crdt.RGATreeList #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 51.11% 51.47% +0.36%
==========================================
Files 66 66
Lines 7008 6962 -46
==========================================
+ Hits 3582 3584 +2
+ Misses 2952 2904 -48
Partials 474 474
|
hackerwins
approved these changes
Aug 2, 2023
dc7303
reviewed
Aug 2, 2023
| @@ -214,7 +214,9 @@ func (p *Array) insertAfterInternal( | |||
| ticket, | |||
| )) | |||
|
|
|||
| p.InsertAfter(prevCreatedAt, value) | |||
| if err = p.InsertAfter(prevCreatedAt, value); err != nil { | |||
| panic(err) | |||
There was a problem hiding this comment.
Could you tell me why panic is called?
I think it's safer to handle errors using errors.
There was a problem hiding this comment.
Oh, are you going to phase it out?
There was a problem hiding this comment.
I thought it is okay to call panic in json according to #497 (comment).
It would be great to change the above logic to handle errors if possible.
I guess one of possible errors can be an error that occurs because of a failure of finding a node for the given createdAt.
func (a *RGATreeList) findNextBeforeExecutedAt(
createdAt *time.Ticket,
executedAt *time.Ticket,
) (*RGATreeListNode, error) {
node, ok := a.nodeMapByCreatedAt[createdAt.Key()]
if !ok {
return nil, fmt.Errorf("fail to find the given createdAt: %s", createdAt.Key())
}
...
}
Would you mind giving me some guides or examples to safely handle errors like the above?
hackerwins
reviewed
Aug 3, 2023
Wu22e
pushed a commit
to Wu22e/yorkie
that referenced
this pull request
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This removes panic in
crdt/rga_tree_listthat should be avoided in production.Which issue(s) this PR fixes:
Related to #497
Special notes for your reviewer:
I guess it would be good to add some test cases for errors.
Would you mind giving me some comments about this?
I'm just planning to add tests for a basic success and the errors included in this pr.
Does this PR introduce a user-facing change?:
Additional documentation
Checklist: